-
Notifications
You must be signed in to change notification settings - Fork 304
Make X86 intrinsics const
#1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sayantn
wants to merge
40
commits into
rust-lang:main
Choose a base branch
from
sayantn:make-const
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+11,103
−6,907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b73089f to
f8fe8b8
Compare
42d6966 to
220fc5a
Compare
2830224 to
ec6eef8
Compare
only ordered intrinsics have implementation in rustc-const-eval
add const-safe version of `assert_eq`
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ik the diffcount is a lot, but most of it is just boilerplate. It is easier to review on a per-commit basis, and the following commits contain the "interesting" bits (other just soulless adding of
constkeyword everywhere)reduce_addandreduce_mulintrinsics to usesimd_reduce_add_orderedandsimd_ordered_mul_ordered, respectively. As integer algebra is associative, it doesn't matter for correctness, and LLVM will use the most performant arrangement. The reason is that rustc_const_eval only implements these ordered reduction intrinsics, unordered reduction seems to be tricky to implement in const_eval)#[simd_test]quite a bit, adds a new "no arguments" mode to ease testing of intrinsics that require no target features and adds support for const testing)Small todo: open a tracking issue for x86 const intrinsics