Skip to content

Conversation

@sayantn
Copy link
Contributor

@sayantn sayantn commented Sep 25, 2025

Ik the diffcount is a lot, but most of it is just boilerplate. It is easier to review on a per-commit basis, and the following commits contain the "interesting" bits (other just soulless adding of const keyword everywhere)

  • 7134a49 (modifies the integer reduce_add and reduce_mul intrinsics to use simd_reduce_add_ordered and simd_ordered_mul_ordered, respectively. As integer algebra is associative, it doesn't matter for correctness, and LLVM will use the most performant arrangement. The reason is that rustc_const_eval only implements these ordered reduction intrinsics, unordered reduction seems to be tricky to implement in const_eval)
  • fa55d7d (modifies #[simd_test] quite a bit, adds a new "no arguments" mode to ease testing of intrinsics that require no target features and adds support for const testing)
  • 391dc70 (rewrites some test helper functions for const)
  • b451207 and 1638f94 (contains some modifications to avoid pointer-to-usize casts and for loops)

Small todo: open a tracking issue for x86 const intrinsics

@sayantn sayantn force-pushed the make-const branch 2 times, most recently from b73089f to f8fe8b8 Compare October 1, 2025 06:02
@sayantn sayantn force-pushed the make-const branch 2 times, most recently from 42d6966 to 220fc5a Compare October 5, 2025 01:49
@sayantn sayantn force-pushed the make-const branch 2 times, most recently from 2830224 to ec6eef8 Compare November 13, 2025 11:44
@sayantn sayantn marked this pull request as ready for review November 23, 2025 06:12
@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants